Subject: Re: [netatalk-admins] Bug? in 4.4BSD kernel code
From: Julian Elischer (julian@whistle.com)
Date: Wed Aug 06 1997 - 08:04:16 EDT
iAs the porter of the netatalk code to freebsd
I'll take a look later today..
I also have some bug-fixes I need to add
so I'll be in the code anyhow.
julian
On Tue, 5 Aug 1997, Bill Studenmund wrote:
> For another network project, I was staring at at_control.c in NetBSD, and
> noticed what looks like a bug. I checked out both the FreeBSD and the
> netatalk/sys/netatalk a_control.c files, and the questionable code is
> there too.
>
> Basically, when we go to set up a new AppleTalk address, we initialize the
> at_ifaddr and link it into the address lists. Then, ifdef BSD4_4, we set
> up the pointers in the ifaddr structure.
>
> My question is why we set the ifaddr's ifa_dstaddr to point to the
> at_ifaddr's NORMAL address, when the at_ifaddr has an AppleTalk
> destination address structure?
>
> The code in question is line 185 of netatalk/sys/netatalk/at_control.c. I
> think the (struct sockaddr *)&aa->aa_addr should be &aa->aa_dstaddr.
>
> Or am I missing something?
>
> Take care,
>
> Bill
>
>
This archive was generated by hypermail 2b28 : Sat Dec 18 1999 - 16:26:00 EST