Subject: [netatalk-admins] Bug? in 4.4BSD kernel code
From: Bill Studenmund (skippy@macro.stanford.edu)
Date: Tue Aug 05 1997 - 15:39:23 EDT
For another network project, I was staring at at_control.c in NetBSD, and
noticed what looks like a bug. I checked out both the FreeBSD and the
netatalk/sys/netatalk a_control.c files, and the questionable code is
there too.
Basically, when we go to set up a new AppleTalk address, we initialize the
at_ifaddr and link it into the address lists. Then, ifdef BSD4_4, we set
up the pointers in the ifaddr structure.
My question is why we set the ifaddr's ifa_dstaddr to point to the
at_ifaddr's NORMAL address, when the at_ifaddr has an AppleTalk
destination address structure?
The code in question is line 185 of netatalk/sys/netatalk/at_control.c. I
think the (struct sockaddr *)&aa->aa_addr should be &aa->aa_dstaddr.
Or am I missing something?
Take care,
Bill
This archive was generated by hypermail 2b28 : Sat Dec 18 1999 - 16:26:00 EST