Subject: Re: [netatalk-admins] Can't stop CR/LF translation...
From: bsmith@h-e.com
Date: Wed Mar 25 1998 - 22:01:37 EST
Original message sent on Wed, Mar 25 5:58 PM by davidw@gate.cks.com (David
Welton) :
> Actually, I went one better (I hope it's seen that way at least!) and
> hacked a new command line option into afpd so that you can turn off
> CR/LF translation by starting it with '-e'. I did this by adding a
> variable in afp_options. I hope this was the right place to put it.
>
> Everything seems to work great now :-)
>
> Anyway, I have attached my diffs for review.
Looks solid to me, the most important thing would be to make sure you got all
the "#ifdef CRLF"s out of there, and it looks like you did.
If you're interested, I did something similar to the code, but my approach was
to add an option to the AppleVolumes file so that translation can be selected
volume-by-volume. This required a lot more changes, because afpd has to
translate in the "copyfile" function where it never had to before, but I've been
using it for several weeks with no problems. You would have to merge the
changes manually because it's based on 1.4b2 (without asun's patches) plus it
changes some of the same places you've already changed. But since you seem to
be comfortable messing about in the code, if you want to take a look I'll be
happy to e-mail it (it's too long to post to the group). Any other netatalk
hackers out there are also welcome to it, just drop me a request!
Bob Smith
Hammett & Edison, Inc.
bsmith@h-e.com
This archive was generated by hypermail 2b28 : Sat Dec 18 1999 - 16:31:57 EST